issue about index value



Support for OS/VS COBOL, VS COBOL II, COBOL for OS/390 & VM and Enterprise COBOL for z/OS

issue about index value

Postby helen2000 » Wed Sep 05, 2012 2:50 am

hello,

my code is:
01  MP-MESSAGE-TABLE.

    05  FILLER               OCCURS      350  TIMES
                             INDEXED BY  MP-MESSAGE-IX.
        10  MP-MESSAGE                   PIC   X(157).
        10  FILLER                       PIC   X(3).


before establish message table always have:
SET ME-MESSAGE-IX TO 1
         SET MP-MESSAGE-IX DOWN BY 1


QUESTION 1: why always put the 2 "set" statement before we access the message table?
question 2: when the first "set" completed, the value of MP-MESSAGE-IX is 1,
but when the second "set" completed, the value of MP-MESSAGE-IX is 'X FFFF60 instead of zero,
thank you for any idea,

Helen
helen2000
 
Posts: 80
Joined: Sat Aug 08, 2009 9:44 pm
Has thanked: 0 time
Been thanked: 0 time

Re: issue about index value

 

Re: issue about index value

Postby Akatsukami » Wed Sep 05, 2012 3:02 am

Are you actually using to different variables, ME-MESSAGE-IX and MP-MESSAGE-IX, or is that a typo?
"You have sat too long for any good you have been doing lately ... Depart, I say; and let us have done with you. In the name of God, go!" -- what I say to a junior programmer at least once a day
User avatar
Akatsukami
Global moderator
 
Posts: 1053
Joined: Sat Oct 16, 2010 2:31 am
Location: Bloomington, IL
Has thanked: 6 times
Been thanked: 51 times

Re: issue about index value

Postby helen2000 » Wed Sep 05, 2012 3:05 am

sorry for the typo error, they are the same variable: MP-message-Ix instead of MP-message-ix
helen2000
 
Posts: 80
Joined: Sat Aug 08, 2009 9:44 pm
Has thanked: 0 time
Been thanked: 0 time

Re: issue about index value

Postby BillyBoyo » Wed Sep 05, 2012 3:35 am

Ok, why the two SETs?

You can't SET an index to ZERO.

So, what some people do to get around this, is SET the index to 1. Then SET the index DOWN BY 1.

Why do you get that hex value?

Firstly, "when the first "set" completed, the value of MP-MESSAGE-IX is 1" is not correct. It is zero.

An index is always a displacement from the start of the OCCURS. Entry one in the OCCURS is displacement zero. That will be the value of the index when you SET it to 1 (because you want the first entry in the table).

This leads to why you can't SET to ZERO. The "zeorth" entry in a table is the -1 entry. Doesn't exist, and if you ever use that index value you'll have a problem. If using SSRANGE you'll set off the trap. If not, you'll be using invalid data which, if you're lucky, will abend, if you're unlucky will be merrily used until you or someone else spots it, hopefully in unit-testing :-)

The third question, which you didn't ask, is "is this a good way to do it"? And the answer is "no".

It is confusing, as you have discovered. It is error-prone in that you always have to treat those two SETs as one, but someone is going to come along and not do that.

If you show some code relating to any "looping" constructs that you have, we can make suggestions of how it could be coded to be less problematic.
BillyBoyo
Global moderator
 
Posts: 3804
Joined: Tue Jan 25, 2011 12:02 am
Has thanked: 22 times
Been thanked: 264 times


Return to IBM Cobol

 


  • Related topics
    Replies
    Views
    Last post