Page 2 of 2

Re: MACROS in JCL.

PostPosted: Thu Apr 22, 2010 1:48 am
by Bad Man
Sorry I mean 82 without the %....

Re: MACROS in JCL.

PostPosted: Thu Apr 22, 2010 2:26 am
by Robert Sample
You need to debug your SAS code. You need to dump the data values and see EXACTLY what the different variable values are. SAS doesn't mess up basic arithmetic, so if it is not triggering on an IF statement, then the condition is not being met -- and it becomes YOUR responsibility to figure out why, hence the data dump suggestion.

If all you are going to do is cry that your code is correct and the computer must be wrong, please find a new profession -- now. Programmers have come to me hundreds of times over the years claiming the computer made a mistake. The times that the eventual cause was discovered NOT to be programmer error I can count on one hand with fingers left over. Accept that your code is wrong, somewhere, and find it, fix it, then move on.

Suggestion: if you are not using OPTIONS MLOGIC MPRINT; in your SAS program, add them and run again. SAS has a lot of options to help debugging; if you are not familiar with them go to http://www.sas.com and look under support at their knowledge base.

Re: MACROS in JCL.

PostPosted: Thu Apr 22, 2010 12:24 pm
by Bad Man
I understand SAS does not mess up basic arithemetic.. This code cannot be wrong as it has been running from a very good time much before I became a sys programmer.. I am definitely not crying that the computer is wrong or the code is not correct..It is just that the changes which I made to SLA_UTIL in this paricular macros are not being taken up and I was just trying to understand is there a way we work diferently with macros...

Now when I got up in the morning with a fresh mind ran the job again with a proc print after the arithemetic which I commented out and found out the problem the product to report on UTILIZATIOn I was reading it in a different manner and now I get it...The MEAN_PCT is lower than 60 its 15 and thats why the mail is not shot..

Thanks and Sorry....

Re: MACROS in JCL.

PostPosted: Thu Apr 22, 2010 5:54 pm
by Robert Sample
Glad to hear you figured it out -- but you could have saved yourself a LOT of time and grief by doing the PROC PRINT in the first place. :)

Re: MACROS in JCL.

PostPosted: Thu Apr 22, 2010 6:41 pm
by Bad Man
I was over confident that the pool is above 60% and thought something in my code is wrong....

Next time I will be slow and analyse things (which is against my attitude :( )